On Sun, Aug 01, 2004 at 04:48:24PM +0200, Peter N. Lundblad wrote:
> What do you mean by "very wrong"? Ofcourse, a simple mistake such as
> swapping an %s with an %d is very wrong, still it is easy to do if your
> language put the words in a different order. I'm not sure every translator
> use tools with format string validation. Also, what would make the change
> not allowed if the translator thinks it is correct and merges it?
Well there shouldn't ever be a circumstance where the format strings in
a translation don't match that in the English version since we don't
have positional formatting codes available. So any difference is a bug.
There's certainly no reason we couldn't develop a tool, probably would
take me 5 minutes, that would make sure the formats match. If there
isn't already such a tool.
Also just because there's no voting doesn't mean there isn't review. We
could even add the running of such a tool to our test suite run. Which
means a release will never have this problem because it'll fail the test
suite run.
> >
> > The only circumstance I really see coming up in practice is adding
> > strings that weren't previously translatable because they weren't
> > wrapped with _(). Those things require voting. So I'd modify the rules
>
> Why is this a problem? If the string is correct in the source, then the
> msgid will be correct in the .po file and, per your logic, the msgstr will
> be correct since a single translator don't make mistakes. Here must be
> something I don't understand...
Because to add a new string requires modification to the C code. We
want to be very cautious about that. I guess I don't get what the
confusion is here.
> I think this is confusing. Changes to .po files that affect msgids are
> made by tools, not people. These rules should concentrate on msgstr
> changes. So, your rule could be rewritten something like:
> Without voting:
> ...
> * Changes to .po files if all format specifiers exactly match the
> correspinding msgid strings regarding (including their order).
Changes are made by tools, but checked in by human beings. An addition
of a msgid to a po file implies a change to a C source file. My
intention is to allow translators to work on .po files freely as long as
they don't modify a C source file.
When I say add a new msgid I mean create one by adding a _() to the C
source code. I'm assuming here that a translator is going to probably
add the _() and then provide the translation additions in the same
voting item.
--
Ben Reser <ben@reser.org>
http://ben.reser.org
"Conscience is the inner voice which warns us somebody may be looking."
- H.L. Mencken
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org
Received on Sun Aug 1 18:31:28 2004