On Thu, 29 Jul 2004, Ben Reser wrote:
> On Thu, Jul 29, 2004 at 08:56:05AM +0200, Peter N. Lundblad wrote:
> >
> >
> > I see that we interpret these differently. What would the second rule
> > allow that the first doesn't under your interpretation?
>
> Right now as far as I'm concerned this rule means as long as you don't
> touch a .c or .h file you're fine. Because you can't go changing the %
> codes without chaing the .c or .h files. Now I suppose someone could
> use a %d interchangeable with a %ld on some platforms. But this all
> should be easy to review. If the % codes on the msgid don't match the
> msgstr then there is probably something very wrong with the change and
> it won't be allowed anyway. If the msgid doesn't match what we have in
What do you mean by "very wrong"? Ofcourse, a simple mistake such as
swapping an %s with an %d is very wrong, still it is easy to do if your
language put the words in a different order. I'm not sure every translator
use tools with format string validation. Also, what would make the change
not allowed if the translator thinks it is correct and merges it?
>
> The only circumstance I really see coming up in practice is adding
> strings that weren't previously translatable because they weren't
> wrapped with _(). Those things require voting. So I'd modify the rules
Why is this a problem? If the string is correct in the source, then the
msgid will be correct in the .po file and, per your logic, the msgstr will
be correct since a single translator don't make mistakes. Here must be
something I don't understand...
> to read as follows to be more clear:
>
> Without voting:
> - Changes to message translations in .po files where the % codes in the
> msgstr are exactly the same (including order) as the % codes in the
> msgid and that do not add new msgids that did not previously exist.
>
> With voting:
> - Changes to message translations in .po files that add a msgid (not
> used in another existing translation) or alter the % codes in an
> existing msgid.
>
I think this is confusing. Changes to .po files that affect msgids are
made by tools, not people. These rules should concentrate on msgstr
changes. So, your rule could be rewritten something like:
Without voting:
...
* Changes to .po files if all format specifiers exactly match the
correspinding msgid strings regarding (including their order).
Regards,
//Peter
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org
Received on Sun Aug 1 16:37:21 2004