[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: svn commit: r10429 - branches/1.1.x/subversion/po

From: Ben Reser <ben_at_reser.org>
Date: 2004-07-29 22:26:50 CEST

On Thu, Jul 29, 2004 at 08:56:05AM +0200, Peter N. Lundblad wrote:
> On Wed, 28 Jul 2004, Ben Reser wrote:
> > On Wed, Jul 28, 2004 at 11:34:38PM +0200, Peter N. Lundblad wrote:
> > > That was the idea when I proposed the change to HACKING some month ago.
> > > Ironically, then, jerenkrantz (I believe) objected saying this rule was
> > > too relaxed. And now, some people want to relax it even more:-)
> >
> > I don't think I'm suggesting that we relax the rule. I thought the rule
> > allowed those changes to be merged. Did I miss something in them? I'm
> > certainly okay with them the way I understand them.
> >
> We have in hacking:
> Without voting:
> ...
> - Changes to message translations in .po files as long as format string
> "%" codes are not touched.
> With voting:
> ...
> - Changes to message translations in .po files with changes to format
> "%" codes.
> I see that we interpret these differently. What would the second rule
> allow that the first doesn't under your interpretation?

Right now as far as I'm concerned this rule means as long as you don't
touch a .c or .h file you're fine. Because you can't go changing the %
codes without chaing the .c or .h files. Now I suppose someone could
use a %d interchangeable with a %ld on some platforms. But this all
should be easy to review. If the % codes on the msgid don't match the
msgstr then there is probably something very wrong with the change and
it won't be allowed anyway. If the msgid doesn't match what we have in
the code then well, the msgstr won't ever be used so there's no harm
as far as stability, though the translation will suffer.

The only circumstance I really see coming up in practice is adding
strings that weren't previously translatable because they weren't
wrapped with _(). Those things require voting. So I'd modify the rules
to read as follows to be more clear:

Without voting:
- Changes to message translations in .po files where the % codes in the
  msgstr are exactly the same (including order) as the % codes in the
  msgid and that do not add new msgids that did not previously exist.

With voting:
- Changes to message translations in .po files that add a msgid (not
  used in another existing translation) or alter the % codes in an
  existing msgid.

Ben Reser <ben@reser.org>
"Conscience is the inner voice which warns us somebody may be looking."
- H.L. Mencken
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org
Received on Thu Jul 29 22:27:11 2004

This is an archived mail posted to the Subversion Dev mailing list.

This site is subject to the Apache Privacy Policy and the Apache Public Forum Archive Policy.