[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: win32 svn 1.1 prompting bug (issue #1916?)

From: Ben Reser <ben_at_reser.org>
Date: 2004-07-28 00:29:23 CEST

On Tue, Jul 27, 2004 at 11:10:07PM +0200, Branko ??ibej wrote:
> I just looked at the apr_poll code, and unless I'm totally blind, it
> will consistently return APR_EBADF on Windows for an APR_POLL_FILE type
> poll. However, the wait_for_input functin in poll.c will blithely ignore
> that error, returning APR_SUCCESS instead, because it thinks it got a
> valid response in the pollset (i.e., it reads from the pollset what it
> wrote into it before the call...). I think this is wrong everywhere, not
> just on Windows.
> I think there's no other choice at this time but to have wait_for_input
> return APR_ENOTIMPL on Windows.

Blah. APR docs say anything not implemented must return a APR_ENOTIMPL.
So what you're saying is the Windows support for apr_poll is incomplete
and doesn't return that. Sounds like a bug in APR.

Ohh well implementing the workaround you suggested.

Ben Reser <ben@reser.org>
"Conscience is the inner voice which warns us somebody may be looking."
- H.L. Mencken
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org
Received on Wed Jul 28 00:29:45 2004

This is an archived mail posted to the Subversion Dev mailing list.

This site is subject to the Apache Privacy Policy and the Apache Public Forum Archive Policy.