[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: svn commit: r10299 - in trunk: . subversion/libsvn_fs

From: <kfogel_at_collab.net>
Date: 2004-07-14 21:12:32 CEST

epg@tigris.org writes:
> Modified:
> trunk/configure.in
> trunk/subversion/libsvn_fs/fs-loader.c
> Log:
> When configured without Berkeley DB, make libsvn_fs default to
> the fsfs back-end.
>
> * configure.in:
> Set DEFAULT_FS_TYPE to "bdb" if configured with Berkeley DB, or
> "fsfs" if not. Publish this to svn_private_config.h with
> AC_DEFINE_UNQUOTED.
>
> * subversion/libsvn_fs/fs-loader.c:
> Don't define DEFAULT_FS_TYPE here; expect it to come from
> svn_private_config.h.

Nice!

One comment:

> Modified: trunk/configure.in
> Url: http://svn.collab.net/viewcvs/svn/trunk/configure.in?view=diff&rev=10299&p1=trunk/configure.in&r1=10298&p2=trunk/configure.in&r2=10299
> ==============================================================================
> --- trunk/configure.in (original)
> +++ trunk/configure.in Wed Jul 14 15:17:50 2004
> @@ -327,6 +327,9 @@
> INSTALL_STATIC_RULES="$INSTALL_STATIC_RULES install-bdb-lib"
> BDB_TEST_DEPS="\$(BDB_TEST_DEPS)"
> BDB_TEST_PROGRAMS="\$(BDB_TEST_PROGRAMS)"
> + DEFAULT_FS_TYPE="bdb"
> +else
> + DEFAULT_FS_TYPE="fsfs"
> fi
>
> if test "$svn_lib_neon" = "yes"; then
> @@ -352,6 +355,8 @@
> [The desired minor version for the Berkeley DB])
> AC_DEFINE_UNQUOTED(SVN_FS_WANT_DB_PATCH, $SVN_FS_WANT_DB_PATCH,
> [The desired patch version for the Berkeley DB])
> +AC_DEFINE_UNQUOTED(DEFAULT_FS_TYPE, "$DEFAULT_FS_TYPE",
> + [The fs type to use by default])
>
> dnl Check for header files ----------------
>
>
> Modified: trunk/subversion/libsvn_fs/fs-loader.c
> Url: http://svn.collab.net/viewcvs/svn/trunk/subversion/libsvn_fs/fs-loader.c?view=diff&rev=10299&p1=trunk/subversion/libsvn_fs/fs-loader.c&r1=10298&p2=trunk/subversion/libsvn_fs/fs-loader.c&r2=10299
> ==============================================================================
> --- trunk/subversion/libsvn_fs/fs-loader.c (original)
> +++ trunk/subversion/libsvn_fs/fs-loader.c Wed Jul 14 15:17:50 2004
> @@ -31,7 +31,6 @@
>
> #include "fs-loader.h"
>
> -#define DEFAULT_FS_TYPE "bdb"
> #define FS_TYPE_FILENAME "fs-type"
>
> /* The implementation of this library is deliberately not separated

Since this is now being exported globally, not just privately within
fs-loader.c, there should be a "SVN_" prefix on it. Maybe

   SVN_FS_DEFAULT_TYPE

for example.

-Karl

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org
Received on Wed Jul 14 22:41:49 2004

This is an archived mail posted to the Subversion Dev mailing list.