On Fri, 9 Jul 2004, Greg Hudson wrote:
> On Fri, 2004-07-09 at 04:51, Peter N. Lundblad wrote:
> > > * Deleting a revprop will work against a 1.1 server. Against a 1.0
> > > server, it will fail with "Connection closed unexpectedly" (server sees
> > > malformed network data and closes the connection). This isn't graceful,
> > > but it's certainly no worse than the assertion failure you get with a
> > > 1.0 client, so I'm not sure how much machinery is warranted making it
> > > fail more gracefully against an old server.
> > >
> > If we added a way for the client to know that it shouldn't issue a
> > change-rev-prop without the value, it can give a better error message.
> > "Connection closed..." is confusing, to say the least.
>
> Uh, sure, there's no question that we *could*, with enough effort,
> produce a better error message in this case. But my point is, the
> simple fix doesn't make it any worse than it was already, and simplicity
> is good.
>
Adding a remove-rev-prop command would be nearly as simple and allows an
informative message. That said, the current fix is clearly an improvement,
but we will still have to answer user question about closed connections
when deleting revprops.
Regards,
//Peter
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org
Received on Fri Jul 9 20:28:28 2004