[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: svn commit: r10185 - in trunk/subversion: include libsvn_ra_svn svnserve

From: Greg Hudson <ghudson_at_MIT.EDU>
Date: 2004-07-09 18:39:12 CEST

On Fri, 2004-07-09 at 04:51, Peter N. Lundblad wrote:
> > * Deleting a revprop will work against a 1.1 server. Against a 1.0
> > server, it will fail with "Connection closed unexpectedly" (server sees
> > malformed network data and closes the connection). This isn't graceful,
> > but it's certainly no worse than the assertion failure you get with a
> > 1.0 client, so I'm not sure how much machinery is warranted making it
> > fail more gracefully against an old server.
> >
> If we added a way for the client to know that it shouldn't issue a
> change-rev-prop without the value, it can give a better error message.
> "Connection closed..." is confusing, to say the least.

Uh, sure, there's no question that we *could*, with enough effort,
produce a better error message in this case. But my point is, the
simple fix doesn't make it any worse than it was already, and simplicity
is good.

> BTW, do we want to document the 1.1 additions to the protocol (I am
> thinking of get-locations and get-file-revs), so other clients know that
> these might fail with "unknown command"?

Well, we do have version control on the file itself, so I'm not sure
that's really necessary. Perhaps we could add a note that the protocol
document may be extended in compatible ways, and people should check out
prior versions if they're interested in interacting with prior-version
clients and servers.

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org
Received on Fri Jul 9 18:39:29 2004

This is an archived mail posted to the Subversion Dev mailing list.