Re: herding 1.1 issues into the corral

Branko Čibej wrote:

> Klaus Rennecke wrote:
>
>> Index: D:/kre/workspace/svn/subversion/libsvn_subr/path.c
>> [...]
>

Oh dear. First, I'd like to apologize for that messy submission. Bad
subject line, messed up log message (no idea why) and the second patch
part missing (path-test.c).

> This should be "#include <apr_lib.h>" and "apr_isxdigit". Otherwise, +1.
> We should make a similar change in svn_path_is_uri_safe.

Oh kay, I'm not as conversant with the apr yet as I'd like to be. There
were references to ctype.h in the existing code so I inferred that it's
OK to use. Will check if there is more stuff around running non-client
side that may need looking at.

> Hm. I hope noone ever tries to port Subversion to an EBCDIC platform,
> because not one of these checks will work correctly there... :-\

Well, considering that the charset for URL is well defined, it may be
best not to use a system function that may use a system-dependent
charset. Hmm. Gonna rethink that a bit.

/Klaus

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org
Received on Wed Jul 7 16:08:01 2004