[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: herding 1.1 issues into the corral

From: Branko ─îibej <brane_at_xbc.nu>
Date: 2004-07-07 10:57:41 CEST

Klaus Rennecke wrote:

>Index: D:/kre/workspace/svn/subversion/libsvn_subr/path.c
>===================================================================
>--- D:/kre/workspace/svn/subversion/libsvn_subr/path.c (revision 10145)
>+++ D:/kre/workspace/svn/subversion/libsvn_subr/path.c (working copy)
>@@ -20,6 +20,7 @@
>
> #include <string.h>
> #include <assert.h>
>+#include <ctype.h> /* for svn_path_uri_decode() */
>
> #include <apr_file_info.h>
>
>@@ -871,7 +872,7 @@
> * RFC 2396, section 3.3 */
> c = ' ';
> }
>- else if (c == '%')
>+ else if (c == '%' && isxdigit (path[i + 1]) && isxdigit (path[i + 2]))
> {
> char digitz[3];
> digitz[0] = path[++i];
>
>
This should be "#include <apr_lib.h>" and "apr_isxdigit". Otherwise, +1.
We should make a similar change in svn_path_is_uri_safe.

Hm. I hope noone ever tries to port Subversion to an EBCDIC platform,
because not one of these checks will work correctly there... :-\

-- Brane

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org
Received on Wed Jul 7 10:57:57 2004

This is an archived mail posted to the Subversion Dev mailing list.