[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: [PATCH] add version queries and version checks (issue 1861)

From: Branko ╚ibej <brane_at_xbc.nu>
Date: 2004-07-06 23:35:43 CEST

Greg Hudson wrote:

>On Tue, 2004-07-06 at 09:58, Branko ╚ibej wrote:
>
>
>>It was for me. Greg Hudson and I disagree, as usual -- you simply got
>>caught in the crossfire. :-)
>>If he doesn't actually veto your second patch, I'll commit it as is.
>>Then I'll start work on the vtables.
>>
>>
>
>I am, in fact, -1 on pointlessly exporting version queries from RA and
>FS modules.
>
>(It's certainly pointful to export it from libsvn_ra_svn, so that's
>fine. And if there were some reason to define the version function in a
>different place from the vtable, then it would make sense. But as far
>as I know, the most sensible implementation of these functions is in a
>static function alongside the vtable definition.)
>
Mm, looks like we have a bit of a misunderstanding there. I thought you
were against putting version queries in the vtables, when you're
actually just objecting to exporting them from the libraries. Is that
correct? If so, I can definitely go along with that.

-- Brane

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org
Received on Tue Jul 6 23:35:49 2004

This is an archived mail posted to the Subversion Dev mailing list.