[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: [PATCH] add version queries and version checks (issue 1861)

From: Greg Hudson <ghudson_at_MIT.EDU>
Date: 2004-07-06 23:01:56 CEST

On Tue, 2004-07-06 at 09:58, Branko ╚ibej wrote:
> It was for me. Greg Hudson and I disagree, as usual -- you simply got
> caught in the crossfire. :-)
> If he doesn't actually veto your second patch, I'll commit it as is.
> Then I'll start work on the vtables.

I am, in fact, -1 on pointlessly exporting version queries from RA and
FS modules.

(It's certainly pointful to export it from libsvn_ra_svn, so that's
fine. And if there were some reason to define the version function in a
different place from the vtable, then it would make sense. But as far
as I know, the most sensible implementation of these functions is in a
static function alongside the vtable definition.)

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org
Received on Tue Jul 6 23:02:07 2004

This is an archived mail posted to the Subversion Dev mailing list.

This site is subject to the Apache Privacy Policy and the Apache Public Forum Archive Policy.