[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: [PATCH] add version queries and version checks (issue 1861)

From: Greg Hudson <ghudson_at_MIT.EDU>
Date: 2004-07-06 18:07:34 CEST

On Tue, 2004-07-06 at 08:03, Branko ╚ibej wrote:
> Edmund Horner wrote:
> > The function svn_ra_svn_version() function remains, since it is
> > checked by svnserve/main.c. Does that sound ok?

That's fine.

> Um. I said in my previous post that I disagree. I think these functions
> should go in, and so should the version check changes in the vtables.
> And there's no need to change the vtables first.

There's certainly no reason they should be library-exported symbols,
outside of ra_svn. They can be defined as static functions in the same
place as the vtable is defined.

Ergo, it's pretty silly to put them in without also extending the
vtable.

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org
Received on Tue Jul 6 20:51:10 2004

This is an archived mail posted to the Subversion Dev mailing list.

This site is subject to the Apache Privacy Policy and the Apache Public Forum Archive Policy.