[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: [PATCH] add version queries and version checks (issue 1861)

From: Branko ─îibej <brane_at_xbc.nu>
Date: 2004-07-07 20:28:16 CEST

Edmund Horner wrote:

> Greg Hudson wrote:
>
>> On Mon, 2004-07-05 at 02:01, Edmund Horner wrote:
>>
>>> However I have added svn_libname__version() functions for the plugin
>>> libraries.
>>
>>
>> Pointless and messy. Until such a time as the vtable work is done to
>> make it possible to query an FS or RA module's version after loading it,
>> don't add any symbols like this.
>>
>> (There's no urgency to doing this work, since the RA/FS ABI version will
>> serve in the meantime.)
>
>
> Righty ho.
>
> I have removed the svn_libname__version() functions from svn_fs_base,
> svn_fs_fs, svn_ra_local, svn_ra_dav.
>
> The function svn_ra_svn_version() function remains, since it is
> checked by svnserve/main.c. Does that sound ok?
>
> Regards, etc.
> Edmund.
>
>
>
> Issue 1861: Implement library version functions, and check library
> versions in command-line clients. Each library features a
> "svn_libname_version" function that returns information on the
> Subversion version the library is compiled as. Clients call their own
> "check_lib_versions" (or a similarly named) function that uses
> svn_ver_check_list (from libsvn_subr/version.c) to call the version
> functions of a list of libraries, which ensures there are no version
> mismatches.
>
> This change is a generalisation of r9697 to other libraries and
> clients.
>
> * subversion/libsvn_delta/version.c (svn_delta_version),
> subversion/libsvn_ra_svn/version.c (svn_ra_svn_version):
> New files, with functions for returning library versions.
>
> * subversion/libsvn_diff/util.c (svn_diff_version),
> subversion/libsvn_fs/fs-loader.c (svn_fs_version),
> subversion/libsvn_ra/ra_loader.c (svn_ra_version),
> subversion/libsvn_repos/repos.c (svn_repos_version),
> subversion/libsvn_wc/util.c (svn_wc_version):
> New functions for returning library versions.
>
> * subversion/include/svn_delta.h (svn_delta_version),
> subversion/include/svn_diff.h (svn_diff_version),
> subversion/include/svn_fs.h (svn_fs_version),
> subversion/include/svn_ra.h (svn_ra_version),
> subversion/include/svn_ra_svn.h (svn_ra_svn_version),
> subversion/include/svn_repos.h (svn_repos_version),
> subversion/include/svn_wc.h (svn_wc_version):
> New function symbols.
>
> * subversion/svnadmin/main.c,
> subversion/svnlook/main.c,
> subversion/svndumpfilter/main.c,
> subversion/svnserve/main.c,
> subversion/svnversion/main.c,
> contrib/client-side/svn-push/svn-push.c:
> (check_lib_versions): New function that checks the compiled
> versions of all svn libraries needed by this client.
> (main): Call check_lib_versions() and exit with failure if library
> versions are not adequate.
>
> * subversion/clients/cmdline/main.c:
> (check_lib_versions): Add remaining library version checks.

Committed in r10167, with minor tweaks (just a few docstrings). Thanks!

Off to the vtables now...

-- Brane

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org
Received on Wed Jul 7 20:28:24 2004

This is an archived mail posted to the Subversion Dev mailing list.