[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: svn commit: r10137 - trunk/subversion/tests

From: Branko Čibej <brane_at_xbc.nu>
Date: 2004-07-05 00:46:00 CEST

rooneg@tigris.org wrote:

>Author: rooneg
>Date: Sun Jul 4 12:16:25 2004
>New Revision: 10137
>
>Modified:
> trunk/subversion/tests/fs-helpers.c
>Log:
>Make the libsvn_repos tests respect the FS_TYPE environment variable so
>that 'make fsfscheck' will run the repository tests over the intended fs
>backend.
>
>* subversion/tests/fs-helpers.c
> (svn_test__create_repos): set the fs type in the config if FS_TYPE is
> present in the environment. don't set the berkeley db errcall if we're
> not creating a bdb filesystem.
>
>
-1 Why use the environment here? Please just pass in a new fs-type
parameter to the helpers, and get fs-test and friends to interpret the
--fs-type option. All other tests do that. We shouldn't start using the
environment for passing in such info. This is just hackish laziness.

By the way, fs-test.c should be split into a BDB-specific part and an
FS-agnostic part, too.

-- Brane

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org
Received on Mon Jul 5 00:47:39 2004

This is an archived mail posted to the Subversion Dev mailing list.