Re: [PATCH) compile warnings from msgfmt

On Thu, 24 Jun 2004, Greg Hudson wrote:

> On Thu, 2004-06-24 at 18:25, Peter N. Lundblad wrote:
> > Here is a patch that gets rid of the warnings if bind_textdomain_codeset
> > is available. This is Portabilityland, where I am a stranger, so please
> > could someone have a look.
>
> It looks functionally okay, but you should restrict lines to 80
> characters when possible, and @IF_NOT_HAVE_BIND_TEXTDOMAIN_CODESET@ is
> perhaps a bit verbose.
>
The only problematic line is the sed line to remove the Content-type
header. I don't know where it is safe to break this line.

About the long names: they are verbose, but consistent with what autoconf
uses (HAVE_functionname). I added IF_ for as a prefix when the condition
is true and IF_NOT_ when it is false.

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org
Received on Sat Jun 26 20:28:27 2004