Re: [PATCH] messages treated non binary (was Re: text MIME types)

On Sun 2004-06-20 at 17:36:03 +0200, Pierre THIERRY wrote:
> > I've just seen that message/* should probably be regarded as text by
> > default.
>
> Index: subversion/libsvn_subr/validate.c
> ===================================================================
> --- subversion/libsvn_subr/validate.c (revision 10034)
> +++ subversion/libsvn_subr/validate.c (working copy)
> @@ -68,5 +68,6 @@
> return ((strncmp (mime_type, "text/", 5) != 0)
> && (strcmp (mime_type, "image/x-xbitmap") != 0)
> && (strcmp (mime_type, "image/x-xpixmap") != 0)
> + && (strcmp (mime_type, "message/") != 0)
> );
> }

Without commenting on whether that change would be a good idea, I
think the patch is broken. Shouldn't it be

  + && (strncmp (mime_type, "message/", 8) != 0)

Bye,

        Benjamin.

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org
Received on Tue Jun 22 01:27:52 2004