[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: svn commit: r10039 - in trunk: . build/generator subversion/bindings/swig subversion/bindings/swig/perl/libsvn_swig_perl subversion/bindings/swig/perl/native

From: Russell Yanofsky <rey4_at_columbia.edu>
Date: 2004-06-21 02:43:33 CEST

Branko ÄOibej wrote:
>>
>> self.name = self.lang + libname
>> self.path = os.path.join(self.path, self.lang)
>> - self.filename = os.path.join(self.path, libfile)
>> + if self.lang == "perl":
>> + self.filename = os.path.join(self.path,
>> libfile[0]+string.capitalize(libfile[1:])) + else:
>> + self.filename = os.path.join(self.path, libfile)
>>
>>
> I don't understand this. What's this for?

Just to give perl modules names like _Client.dll and _Core.dll instead of
_client.dll and _core.dll. It's probably not neccessary on Windows, but I
was just being cautious.

>> + # perl bindings do their own thing, "install-swig-pl" target
>> is + # already specified in Makefile.in
>> + if area == "swig-pl":
>> + continue
>> +
>> # get the output files for these targets, sorted in dependency
>> order files = gen_base._sorted_files(self.graph, area)
>>
>>
> This is exactly the kind of exceptions we don't need. Is there really
> no way to handle the perl SWIG bindings the same way as any other SWIG
> bindings? At the very least, this should be handled with a _property_
> of the section in build.conf, the generator shouldn't depend on the
> section name.

Technically, it depends on the install name, not the section name. And the
generator code already makes similar exceptions. I agree that it would be
nice if the perl bindngs built the same way as other SWIG bindings on unix,
but they don't, and I don't know enough about perl or the unix build system
to make them do that. I can change the code above though.

>
>> +#ifdef _MSC_VER
>> +#define snprintf _snprintf
>> +#endif
>>
>>
> Put this in defines instead. We do the same with alloca.
>
>> +#ifdef _MSC_VER
>> +#define strtoll(str, endptr, base) atoi(str)
>> +#endif
>>
>>
> That's asking for trouble. Use _strtoi64 with MSVC 7 and above (#if
> _MSC_VER >= 1300 && _INTEGRAL_MAX_BITS >= 64). Use _atoi64 otherwise.
>

Ok, thanks for the information. I'll clean these up.

- Russ

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org
Received on Mon Jun 21 02:44:01 2004

This is an archived mail posted to the Subversion Dev mailing list.

This site is subject to the Apache Privacy Policy and the Apache Public Forum Archive Policy.