Re: svn commit: r10037 - in trunk: build/generator build/win32 subversion/bindings/swig

Branko ÄOibej wrote:
> So now you took all the work that was done in order to support both
> versions of SWIG on Windows (like we do on Unix) out of the window.
> Also, whoever wants to build both 1.0.x and trunk must now have _two_
> versions of SWIG installed. All that without discussion on the dev@
> list.
>
> -1

Sorry, I didn't realize that 1.0 builds still required SWIG 1.3.19.

> There's no reason to drop this compatibility,

The reason to drop compatibility is just that implementing it is complicated
and invasive. The new implementation lets swig generate the runtime instead
of concatenating internal swig source files and making assumptions about
where the files are and what they contain.

> and I strongly object to
> the way it was done (i.e., throwing away all parametrisation of SWIG
> options).

Why should SWIG options be parameterized if they don't change?

> If generating the SWIG runtime is a problem (which I don't
> see why it would be), then let's instead tell people to build the SWIG
> runtime libraries themselves -- swigwin provides the necessary .dsp
> files

The runtime still gets generated with this change, so it's not a problem.

> Please revert this change until we've discussed it and you convince me
> it's necessary at this point.

I reverted the change in r10040. I don't think we should bring it back until
SWIG 1.3.19 is out of the picture.

- Russ

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org
Received on Mon Jun 21 02:03:36 2004