Re: [PATCH] Issue 1846, RA layer part, take 2

+ /* Read the hash items. */
+ is_done = FALSE;
+
+ *locations = apr_hash_make(pool);
+
+ /* ### Check for error and return not implemented. */
+ while (!is_done)

Okay, first, those blank lines aren't really doing anything except
visually separating the /* Read the hash items. */ comment from the code
it's talking about. Second, the ### comment should go, if it's talking
about what I think it's talking about. If the server encounters an
error, it will write out "done" and then send an error in the command
response.

Otherwise, everything but the DAV part looks okay to me. Fortunately,
the above is just a cosmetic change, so it shouldn't require another
iteration of testing.

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org
Received on Sat Jun 19 00:21:40 2004