Re: svn_repos_trace_node_locations()

On Thu, 10 Jun 2004, Greg Hudson wrote:

> On Thu, 2004-06-10 at 17:18, Peter N. Lundblad wrote:
> + if (! history)
> + *is_ancestor = FALSE;
> + else
> + *is_ancestor = (strcmp(path, fs_path) == 0);
>
> *is_ancestor = (history && strcmp (path, fs_path) == 0);
>
> Whether to collapse the expression is a style call, but either way there
> should be a space before the paren after strcmp.
>
I choose your solution.

> + lastpool = svn_pool_create(pool);
>
> Likewise here.
>
> + const char *p = apr_hash_get(locations, &info->rev, sizeof
> + (svn_revnum_t));
>
> And here.
>
Fixed. Thanks.

I'm going to commit this part now.

Regards,
//Peter

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org
Received on Fri Jun 11 14:25:42 2004