Re: svn_repos_trace_node_locations()

On Thu, 2004-06-10 at 17:18, Peter N. Lundblad wrote:
> I've reworked the first part of Shlomi's patch for the node-locations
> stuff. I don't think this part was reviewed before, so I could well have
> use for a pair of eyes.

It looks good to me. Small nits:

+ if (! history)
+ *is_ancestor = FALSE;
+ else
+ *is_ancestor = (strcmp(path, fs_path) == 0);

*is_ancestor = (history && strcmp (path, fs_path) == 0);

Whether to collapse the expression is a style call, but either way there
should be a space before the paren after strcmp.

+ lastpool = svn_pool_create(pool);

Likewise here.

+ const char *p = apr_hash_get(locations, &info->rev, sizeof
+ (svn_revnum_t));

And here.

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org
Received on Fri Jun 11 04:28:57 2004