[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: [PATCH] Resolve compile warnings seen with Forte

From: Justin Erenkrantz <justin_at_erenkrantz.com>
Date: 2004-05-31 06:12:15 CEST

On Mon, May 31, 2004 at 12:02:22AM -0400, Greg Hudson wrote:
> -static void hex_encode(char *hexval, const char *hashval)
> +static void hex_encode(unsigned char *hexval, const unsigned char *hashval)
> hexval should remain a char *.

Oooh, yah, I got confused on what hexval was doing. I'll also keep hex in
cram_client as a signed char, and just make digest unsigned.

> - unsigned char *buf;
> + char *buf;
> You're right that this situation requires casting (we want to read a
> bunch of bytes and treat them as unsigned char values), but better to
> leave the buffer as unsigned char * and cast the svn_stream_read
> parameter.

Fair enough. Thanks! -- justin

To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org
Received on Mon May 31 06:12:39 2004

This is an archived mail posted to the Subversion Dev mailing list.

This site is subject to the Apache Privacy Policy and the Apache Public Forum Archive Policy.