[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: [PATCH] Resolve compile warnings seen with Forte

From: Greg Hudson <ghudson_at_MIT.EDU>
Date: 2004-05-31 06:02:22 CEST

-static void hex_encode(char *hexval, const char *hashval)
+static void hex_encode(unsigned char *hexval, const unsigned char *hashval)

hexval should remain a char *.

- unsigned char *buf;
+ char *buf;

You're right that this situation requires casting (we want to read a
bunch of bytes and treat them as unsigned char values), but better to
leave the buffer as unsigned char * and cast the svn_stream_read
parameter.

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org
Received on Mon May 31 06:02:38 2004

This is an archived mail posted to the Subversion Dev mailing list.

This site is subject to the Apache Privacy Policy and the Apache Public Forum Archive Policy.