Re: Bug: svn-1.0.4 stops at 65536 revisions

Øyvind A. Holm wrote:

> to see how Subversion performed when it contained lots of revisions. The
> result was pretty ok, there were no significant loss in speed. But when
> it reached 65536 revisions it aborts with this message before the
> checkin is completed:

The number you quote is exactly 2**16, which is the largest value for an
  unsigned short int (typically 2**16-1 actually). And a quick look at
the source suggests that should probably be this (from svn_types.h):

        typedef long int svn_revnum_t;

So why is that much smaller number being used? Is there something in
the code which is trying to fit a long int into an unsigned int slot?
Could you load that core file again and give us a backtrace to see where
it blew up (before it got the the system libraries your strace showed)?

As an aside to the list, why is this not

        typedef unsigned long int svn_revnum_t;

instead (since negative revision numbers make little sense)? I admit
that 2 billion revisions seems large enough, but why settle for that
when you can have 4 billion. ;) Obviously that's a version 2.0.0
question...

John

-- 
John Peacock
Director of Information Research and Technology
Rowman & Littlefield Publishing Group
4501 Forbes Boulevard
Suite H
Lanham, MD  20706
301-459-3366 x.5010
fax 301-429-5748
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org