Re: API cleanups for 2.0 (was Re: Issue 780 and status and notify functions)

Greg Hudson <ghudson@MIT.EDU> writes:

> 1. Callbacks should always have pool arguments. Otherwise we wind up
> creating and destroying subpools in the callbacks, which is
> anachronistic and less efficient than the usual iteration-pool
> approach. Specific places I have noticed lack of callbacks include the
> svn_stream callbacks and svn_txdelta_window_handler_t.

Also, all callbacks should return svn_error_t's.

> 3. svn_fs_unparse_id should return a C string.

+1

> 4. The relationship between svn_fs_abort_txn and svn_fs_purge_txn feels
> strange and implementation-dependent. Perhaps the easiest answer is to
> ditch svn_fs_abort_txn() and make svn_fs_purge_txn() work on live
> transactions.

If we do this, then "abort" is probably the right unified function
name to use.

> 6. Notification callbacks should have an error return, not a void
> return.

See previous comment re: callbacks.

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org
Received on Mon May 24 17:30:05 2004