[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: [PATCH] sprintf elimination, take 2

From: Erik Huelsmann <e.huelsmann_at_gmx.net>
Date: 2004-05-13 20:24:15 CEST

> > > > statements inside the if(detailed) clause). I wonder why you didn't
> > > > change all sprintf's throughout the code, e.g. those in
> > > libsvn_repos/dump.c?
> > > >
> > > Did in that file too, now. NOw we just have sprintf in test cases (who
> > > cares?), svndumpfilter/main.c (missing pool arguments) and utf.c and
> [...]
> > Changing the function signature in svndumpfilter/main.c would be fine.
> > There is no change in the public API by adding a pool paramater to a
> private
> > function. I should have been more exact.
> >
> This could be another patch. It has a svn_stringbuf_t argument. Could I
> use the pool of the string buffer for this temporary allocation?

Given Brane's reaction I'd say there is only a need if too few bytes are
allocated... Otherwise it may be a good idea to go back to the i18n work
(if you don't mind, ofcourse). I got distracted from resolving issue 897
about half a year ago and did not find the time to get back on it yet...



"Sie haben neue Mails!" - Die GMX Toolbar informiert Sie beim Surfen!
Jetzt aktivieren unter http://www.gmx.net/info
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org
Received on Thu May 13 20:26:04 2004

This is an archived mail posted to the Subversion Dev mailing list.

This site is subject to the Apache Privacy Policy and the Apache Public Forum Archive Policy.