Re: [PATCH] svn_cmdline_printf and friends, take2

On Wed, 12 May 2004, Nicolás Lichtmaier wrote:

> >+svn_error_t *svn_cmdline_printf (apr_pool_t *pool,
> >+ const char *fmt,
> >+ ...);
> >
> >
>
> By using "printf" subversion has been taking advantage of a GCC feature:
> to report error in format strings. This is a very good thing, as thee
> inconsistencies are common and can be fatal. It would be wise to add the

Very good idea. svn_error_createf already does that.

It seems like APR (apr.h) defines __attribute__ for us if we're not on a
recent enough GCC, so we could probably just add what you proposed. I'll
do that.

> And it would be useful to add the --flag option to the xgettext
> invocation so that format strings are properly marked as such.
>
This is important for strings without format specifiers if I understand
correctly. Probably should be done for svn_error_createf too.

Thanks,
//Peter

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org
Received on Wed May 12 17:41:03 2004