Re: [PATCH] svn_cmdline_printf and friends, take2

>+svn_error_t *svn_cmdline_printf (apr_pool_t *pool,
>+ const char *fmt,
>+ ...);
>
>

By using "printf" subversion has been taking advantage of a GCC feature:
to report error in format strings. This is a very good thing, as thee
inconsistencies are common and can be fatal. It would be wise to add the
gettext "hint" informing that these functions are "printf like".

It would be:

svn_error_t *svn_cmdline_printf (apr_pool_t *pool,+ const char *fmt,+ ...)
        __attribute__ ((format (printf, 2, 3)));

Of course, this should be only done for GCC.

GLib has a macro for this, which is defined to do nothing if !GCC:

http://developer.gnome.org/doc/API/2.0/glib/glib-Miscellaneous-Macros.html#G-GNUC-PRINTF-CAPS

And it would be useful to add the --flag option to the xgettext
invocation so that format strings are properly marked as such.

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org
Received on Wed May 12 15:06:01 2004