[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: [PATCH] Re: replacing SVN_REVNUM_T_FMT for translation

From: Branko ─îibej <brane_at_xbc.nu>
Date: 2004-05-12 04:19:33 CEST

Peter N. Lundblad wrote:

>On Mon, 10 May 2004 kfogel@collab.net wrote:
>
>
>
>>"Peter N. Lundblad" <lundblad@softhome.net> writes:
>>
>>
>>>>Good. Let's ditch SVN_REVNUM_T_FMT then, and rplace all instances with
>>>>%ld. GCC will warn if somebody uses the wrong format, anyway.
>>>>
>>>>
>>>OK. I'll wait until Wednesday or something and then prepare a patch to
>>>shit effect. Any objections?
>>>
>>>
>>Careful, your Freud is showing, Peter.
>>
>>:-)
>>
>>
>>
>OK, it is not Wednesday yet, and I've tried not to sneak in any bad words
>in the patch, but anyway, here it is. I've eliminated SVN_REVNUM_T_FMT in
>all .c files and replaced with ld.
>
>
Yes. Good. +1.

Also please add a @deprecated note to the SVN_REVNUM_T_FMT docstring:

    @deprecated Provided for backward compatibility with the 1.0 API.

By the way, here's a chance for another simple patch for somebody.
Currently all our @deprecated notes are like the example above, except
that they talk about the 1.0.0 API, not the 1.0 API. Since the third
component of the version number cannot affect the API, I suggest
changing all the 1.0.0's to 1.0.

-- Brane

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org
Received on Wed May 12 04:22:04 2004

This is an archived mail posted to the Subversion Dev mailing list.

This site is subject to the Apache Privacy Policy and the Apache Public Forum Archive Policy.