[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: [PATCH] Issue #1093: make diff follow history

From: Ben Collins-Sussman <sussman_at_collab.net>
Date: 2004-05-12 04:04:57 CEST

Josh Pieper wrote:

> kfogel@collab.net wrote:
>>>The patch could be applied nearly as is with no loss in functionality,
>>>but you won't get much benefit since diffs over renames still won't be
>>>what you expect. If that approach sounds good, I will clean up the
>>>work so far and post it again for review. Otherwise we can wait until
>>>the update driver issue is figured out.
>>Can we anchor the update editor higher up, maybe, like at root?
>>(Thinking out loud, not able to do in-depth analysis atm...)
> Yes, but that is only half the problem. If the file itself is
> renamed, the update driver always issues a complete removal of the old
> file, which causes the diff output to be less than useful.

Hold on: svn_repos_dir_delta() is the ultimate driver of all editors,
if you trace back far enough in any stack. My memory tells me that it
has a mode which tells it to "be stupid", i.e. ignore ancestry. For
example, when you pass the --ignore-ancestry switch to 'svn merge', it
will never delete and re-add something; it just does ignorant
path-based comparisons.

Or is the problem completely unrelated to ancestry?

To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org
Received on Wed May 12 04:08:17 2004

This is an archived mail posted to the Subversion Dev mailing list.

This site is subject to the Apache Privacy Policy and the Apache Public Forum Archive Policy.