[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: [PATCH] SVN_REVFMT_T -> svn_revnum_to_cstring

From: Branko Čibej <brane_at_xbc.nu>
Date: 2004-05-08 19:38:10 CEST

Peter N. Lundblad wrote:

>Attached is a little one that turns most uses of SVN_REVNUM_T_FMT into %s
>and calls to svn_revnum_to_cstring in *printf functions. Mostly it is
>error messages and other user messages that I've touched. I haven't
>modified things that aren't supposed to be localized later.
Let's all take a deep breath now. The more I look at these patches, the
more horrible they seem. svn_revnum_t is typedefed to "long int", and
SVN_REVNUM_T_FMT is %ld. If we don't intend to change that (and
obviously we don't, in the forseeable future) then all of these changes
are nonsense and needless complication. Let's just use %ld and be done
with it.

-- Brane

To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org
Received on Sat May 8 19:40:37 2004

This is an archived mail posted to the Subversion Dev mailing list.

This site is subject to the Apache Privacy Policy and the Apache Public Forum Archive Policy.