[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: Compile error in ra_svn was Re: 1.0.2 build error on AIX 4.3.2, 4.3.3, 5.1, 5.2

From: Greg Hudson <ghudson_at_MIT.EDU>
Date: 2004-05-04 21:22:04 CEST

On Tue, 2004-05-04 at 14:42, Justin Erenkrantz wrote:
> FWIW, I get the same error with Sun's C compiler. And, I have the same
> patch applied locally as well. However, I think we brought this up before
> and GregH didn't seem overly enthusiastic for anyone to commit it.

I thought this was taken care of in r8343. I guess not.

At any rate, I'd appreciate if people would put a little more effort
into getting the variable declarations right rather than just bashing
stuff with casts. Let me know if this patch works:

Index: subversion/libsvn_ra_svn/cram.c
--- subversion/libsvn_ra_svn/cram.c (revision 9618)
+++ subversion/libsvn_ra_svn/cram.c (working copy)
@@ -49,7 +49,7 @@
   return (v < 10) ? '0' + v : 'a' + (v - 10);
-static svn_boolean_t hex_decode(char *hashval, const char *hexval)
+static svn_boolean_t hex_decode(unsigned char *hashval, const char *hexval)
   int i, h1, h2;
@@ -75,7 +75,7 @@
-static void compute_digest(char *digest, const char *challenge,
+static void compute_digest(unsigned char *digest, const char *challenge,
                            const char *password)
   unsigned char secret[64];
@@ -134,7 +134,7 @@
   apr_status_t status;
   apr_uint64_t nonce;
   char hostbuf[APRMAXHOSTLEN + 1];
- char cdigest[APR_MD5_DIGESTSIZE], sdigest[APR_MD5_DIGESTSIZE];
+ unsigned char cdigest[APR_MD5_DIGESTSIZE], sdigest[APR_MD5_DIGESTSIZE];
   const char *challenge, *sep, *password;
   svn_ra_svn_item_t *item;
   svn_string_t *resp;

To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org
Received on Tue May 4 21:22:26 2004

This is an archived mail posted to the Subversion Dev mailing list.

This site is subject to the Apache Privacy Policy and the Apache Public Forum Archive Policy.