--On Monday, May 3, 2004 3:48 PM -0500 Albert Chin
<subversion-dev@mlists.thewrittenword.com> wrote:
> Is the patch below acceptable? The prototype for apr_md5_final() is:
> apr_status_t apr_md5_final(unsigned char digest[16],
> apr_md5_ctx_t *context);
> and digest is of type 'char *':
> static void compute_digest(char *digest, const char *challenge,
> const char *password)
>
> The main reason for the problem is the addition of -qHALT=E to CFLAGS
> by apr/build/apr_hints.m4. This causes a compiler failure on these
> errors while otherwise the compiler would not fail.
FWIW, I get the same error with Sun's C compiler. And, I have the same
patch applied locally as well. However, I think we brought this up before
and GregH didn't seem overly enthusiastic for anyone to commit it.
*shrug* -- justin
> --- subversion/libsvn_ra_svn/cram.c.orig Mon May 3 15:42:00 2004
> +++ subversion/libsvn_ra_svn/cram.c Mon May 3 15:42:08 2004
> @@ -96,13 +96,13 @@
> apr_md5_init(&ctx);
> apr_md5_update(&ctx, secret, sizeof(secret));
> apr_md5_update(&ctx, challenge, strlen(challenge));
> - apr_md5_final(digest, &ctx);
> + apr_md5_final((unsigned char *)digest, &ctx);
> for (i = 0; i < sizeof(secret); i++)
> secret[i] ^= (0x36 ^ 0x5c);
> apr_md5_init(&ctx);
> apr_md5_update(&ctx, secret, sizeof(secret));
> apr_md5_update(&ctx, digest, APR_MD5_DIGESTSIZE);
> - apr_md5_final(digest, &ctx);
> + apr_md5_final((unsigned char *)digest, &ctx);
> }
>
> /* Fail the authentication, from the server's perspective. */
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
> For additional commands, e-mail: dev-help@subversion.tigris.org
>
>
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org
Received on Tue May 4 20:42:43 2004