Re: [PATCH]: Issue #1093, request for extra eyes

Josh Pieper <jpieper@andrew.cmu.edu> writes:

> Second, I factorized some code from several of the client commands,
> but there didn't seem an appropriate file in libsvn_client to put it
> in and I wasn't sure if my function naming convention gelled with the
> rest of the code. My questions: Is the new file 'util.c' appropriate?
> Is the name svn_client__get_ra_from_path_or_url too verbose or
> otherwise not good?

Wouldn't libsvn_client/ra.c do the trick? Seems appropriately scoped
for a function named such as yours.

As for the name itself, "get_ra" doesn't really mean anything to me,
and "_from_path_or_url" can probably be reduced to "_from_path", or
eliminated altogether.

So how about libsvn_client/ra.c:svn_client__ra_lib_from_path?

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org
Received on Tue May 4 15:44:51 2004