[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: fs-test "unopened FS object" tests: fair or unfair?

From: <kfogel_at_collab.net>
Date: 2004-04-27 18:24:21 CEST

Greg Hudson <ghudson@MIT.EDU> writes:
> > My opinion is to get rid of svn_fs_new. Have the open and create do the
> > svn_fs_new work. I talk about it in my document in my API visible
> > changes section. I even mention the fact that this test could go away.
> That's fine for svn 2.0, but we also need an answer for svn 1.x.

I was thinking:

   1. Create new function, svn_fs_open_berkeley2(), which just does

         fs = svn_fs_new();
         svn_fs_open_berkeley(&fs, path_to_berkeley_repos);
         return fs;

   2. Change all callers who currently do two calls to simply call
      svn_fs_open_berkeley2() instead.

   3. Mark svn_fs_new() and svn_fs_open_berkeley() as deprecated.

... or some variant thereof.


To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org
Received on Tue Apr 27 19:36:34 2004

This is an archived mail posted to the Subversion Dev mailing list.

This site is subject to the Apache Privacy Policy and the Apache Public Forum Archive Policy.