On 16 apr 2004, at 16.04, kfogel@collab.net wrote:
> David Remahl <david@ittpoi.com> writes:
>> [[First patch, I hope I'm doing this right -- testing my patch
>> submission skills on documentation ;-)]]
>
> Heh -- almost perfect, just a few problems. I assume you want
> feedback on process as well as the patch itself, so:
>
> 1. It's easiest if you just write a log message (as per HACKING). The
> intro part of your email provided the same information, but it
> would have had to be reformatted to become a log message anyway.
>
> 2. Always generate patches from the top of your working copy. That
> is, the path to the file to patch should be www/project_faq.html,
> not just project_faq.html. (Not a big deal, it just makes things a
> bit easier for the person applying the patch.) Just running
> 'svn diff' from the top of the working copy should do the trick.
>
> 3. Your mailer wraps long lines, therefore your patch won't apply :-).
> Solution: either turn off the line wrapping, or send the patch as
> an attachment so it doesn't get munged.
>
> Other than that, it looks like a great addition to the FAQ!
>
> Want to have a second go? I'll watch for a repost, and apply it.
>
> -Karl
Ok, lets try again ;-). I'm still a bit unclear about exactly where to
put the log message, it shouldn't be part of the patch somehow, should
it?
Log message:
* www/project_faq.html Adding a question about where to find a high-res
version
of the Subversion logo, suitable for printing.
Patch follows as an attachment. (However, the lines of my last patch do
not appear cut off in my mail client, neither before sending, nor after
passing the mailing list...But I better post as an attachment anyway.)
/ Regards, David Remahl
--- PGP key information---
pub 1024D/ 87256085 2003/06/12 David Remahl <david@remahl.se>
Web: http://ittpoi.com/david_remahl.asc
Fingerprint: 0C38 293C 86A9 7756 9CEA 4ED6 1651 620E 8725 6085
Received on Fri Apr 23 10:37:08 2004