David Remahl <david@ittpoi.com> writes:
> [[First patch, I hope I'm doing this right -- testing my patch
> submission skills on documentation ;-)]]
Heh -- almost perfect, just a few problems. I assume you want
feedback on process as well as the patch itself, so:
1. It's easiest if you just write a log message (as per HACKING). The
intro part of your email provided the same information, but it
would have had to be reformatted to become a log message anyway.
2. Always generate patches from the top of your working copy. That
is, the path to the file to patch should be www/project_faq.html,
not just project_faq.html. (Not a big deal, it just makes things a
bit easier for the person applying the patch.) Just running
'svn diff' from the top of the working copy should do the trick.
3. Your mailer wraps long lines, therefore your patch won't apply :-).
Solution: either turn off the line wrapping, or send the patch as
an attachment so it doesn't get munged.
Other than that, it looks like a great addition to the FAQ!
Want to have a second go? I'll watch for a repost, and apply it.
-Karl
> Adding a question to the General section of the FAQ, about where to
> get a version of the Subversion logo suitable for printing.
>
> The question is added right before the "catch all" question of the
> General section, and reads:
>
> 14. I need a high resolution version of the Subversion
> logo, where can I get it?
>
> The answer is that the trunk/www/logo directory of the repository
> contains vectorized versions of the logo.
>
> // David Remahl
>
> Index: project_faq.html
> ===================================================================
> --- project_faq.html (revision 9374)
> +++ project_faq.html (working copy)
> @@ -31,8 +31,10 @@
> own revision numbers. </a></li>
> <li><a href="#changesets">Does Subversion have changesets?</li>
> <li>When's the next release?</li>
> +<li><a href="#logo">I need a high resolution version of the
> Subversion logo,
> + where can I get it?</a></li>
> <li><a href="#more-information">I have other questions. Where can I
> get more information?</a></li>
> + get more information?</a></li>
> <p>
> <strong>How-to:</strong>
> </p>
> @@ -377,6 +379,22 @@
>
> <![CDATA[-----------------------------------------------------------]]>
>
> +<h3><a name="logo">I need a high resolution version of the Subversion
> logo,
> + where can I get it?</a></h3>
> +
> +<p>Vectorized versions of the Subversion logo are available in the <a
> +href="http://svn.collab.net/repos/svn/trunk/www">logo directory of
> the www
> +tree</a> of the <a
> href="http://svn.collab.net/repos/svn/trunk">Subversion
> +repository</a>.</p>
> +
> +<p>Specifically, an <a
> +href="http://svn.collab.net/repos/svn/trunk/www/logo/
> subversion_logo.eps">EPS
> +version</a>, as well as an <a
> +href="http://svn.collab.net/repos/svn/trunk/www/logo/
> subversion_logo.ai">Adobe
> +Illustrator document</a> are available.</p>
> +
> +<![CDATA[-----------------------------------------------------------]]>
> +
> <h3>I have other questions. Where can I get more<a
> name="more-information"> information?</a></h3>
>
>
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
> For additional commands, e-mail: dev-help@subversion.tigris.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org
Received on Fri Apr 16 17:19:32 2004