[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: [PATCH] gettext on Win32

From: D.J. Heap <dj_at_shadyvale.net>
Date: 2004-04-12 05:58:22 CEST

Branko Čibej wrote:

> D.J. Heap wrote:
>
>
>>Index: build.conf
>>===================================================================
>>--- build.conf (revision 9303)
>>+++ build.conf (working copy)
>>@@ -248,6 +248,7 @@
>>type = i18n
>>path = subversion/po
>>install = locale
>>+external-project = build/win32\svn_locale
>>
>>
>
> I think we should do away with backslashes as dir separators in
> build.conf...
>

Good idea.

>
>>@@ -453,6 +470,10 @@
>> if self.dblibname:
>> fakedefines.append("APU_HAVE_DB=1")
>>
>>+ # check if they wanted nls
>>+ if self.enable_nls:
>>+ fakedefines.append("ENABLE_NLS")
>>+
>> return fakedefines
>>
>>
>
> Do we want to use "ENABLE_NLS" rather than "SVN_ENABLE_NLS"?

I was trying to follow the unix stuff -- or do you mean change it just
in the Windows stuff and define ENABLE_NLS if SVN_ENABLE_NLS is defined?

>
>
>>Index: svn_private_config.hw
>>===================================================================
>>--- svn_private_config.hw (revision 9303)
>>+++ svn_private_config.hw (working copy)
>>@@ -48,8 +48,16 @@
>>/* Defined to be the path to the installed binaries */
>>#define SVN_BINARY_DIR "/usr/local/bin"
>>
>>-/* Until Win32 gets gettext functionality, leave these disabled. */
>>+/* Setup gettext macros */
>>#define N_(x) (x)
>>+#ifdef ENABLE_NLS
>>+#define PACKAGE_NAME "subversion"
>>+#define SVN_LOCALE_DIR "C:\\Stuff\\gettext\\share\\locale"
>>
>>
>
> Ouch.
> I know this is just a default (I expect you can override it in the
> config file?), but even so...
> Ah, the joys of Windows. :-)

Yeah, I'll be addressing this somehow before committing -- you think a
config file option would be preferable to using a relative path based on
the (dynamically located with GetModuleFileName or something) path to
the gettext dll? I'm not sure where exactly all that stuff needs to go
on Windows...

DJ

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org
Received on Mon Apr 12 05:56:50 2004

This is an archived mail posted to the Subversion Dev mailing list.

This site is subject to the Apache Privacy Policy and the Apache Public Forum Archive Policy.