Re: [PATCH] gettext on Win32

D.J. Heap wrote:

>Index: build.conf
>===================================================================
>--- build.conf (revision 9303)
>+++ build.conf (working copy)
>@@ -248,6 +248,7 @@
> type = i18n
> path = subversion/po
> install = locale
>+external-project = build/win32\svn_locale
>
>
I think we should do away with backslashes as dir separators in
build.conf...

>@@ -453,6 +470,10 @@
> if self.dblibname:
> fakedefines.append("APU_HAVE_DB=1")
>
>+ # check if they wanted nls
>+ if self.enable_nls:
>+ fakedefines.append("ENABLE_NLS")
>+
> return fakedefines
>
>
Do we want to use "ENABLE_NLS" rather than "SVN_ENABLE_NLS"?

>Index: svn_private_config.hw
>===================================================================
>--- svn_private_config.hw (revision 9303)
>+++ svn_private_config.hw (working copy)
>@@ -48,8 +48,16 @@
> /* Defined to be the path to the installed binaries */
> #define SVN_BINARY_DIR "/usr/local/bin"
>
>-/* Until Win32 gets gettext functionality, leave these disabled. */
>+/* Setup gettext macros */
> #define N_(x) (x)
>+#ifdef ENABLE_NLS
>+#define PACKAGE_NAME "subversion"
>+#define SVN_LOCALE_DIR "C:\\Stuff\\gettext\\share\\locale"
>
>
Ouch.
I know this is just a default (I expect you can override it in the
config file?), but even so...
Ah, the joys of Windows. :-)

>+#include <locale.h>
>+#include <libintl.h>
>+#define _(x) dgettext(PACKAGE_NAME, x)
>+#else
> #define _(x) (x)
>+#endif
>
>
Very nice, otherwise. :-)

-- 
Brane Čibej   <brane_at_xbc.nu>   http://www.xbc.nu/brane/
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org