Re: svn commit: r9320 - trunk/subversion/libsvn_fs_fs

Hi Greg,

I've wondered about this a few times now seeing commits for libsvn_fs_fs,
but ...

> Log:
> Add working-but-unfinished code to convert a dumpfile to a rev file.
>
> * libsvn_fs_fs/make-revs.c
> The converter. The quality of this code isn't great, but it's only
> for generating test cases and will eventually go away. It stores
> the node-rev metadata for the entire dumpfile in memory in a
> succession-of-trees form, and only works for dumpfiles starting at
> rev 0.
>
> The converter does not yet generate proper node-IDs, does not write
> out changed-path information, does not write out rev-props, and does
> not know what to do with a uuid.
>
> I build this code with:
> libtool cc -g -Wall -I$svninst/include/subversion-1 \
> -I$svninst/include/apr-0 -L$svninst/lib make-revs.c \
> -o make-revs -lsvn_repos-1

... don't belong comments like these in comment blocks in your code instead
of in the log message?

bye,

Erik.

-- 
NEU : GMX Internet.FreeDSL
Ab sofort DSL-Tarif ohne Grundgebühr: http://www.gmx.net/info
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org