[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: [PATCH] More _() added

From: Erik Huelsmann <e.huelsmann_at_gmx.net>
Date: 2004-04-11 09:47:43 CEST

Hi Nicolas,

> Here's another round of _()'s added everywhere.

I shortly reviewed this patch (as I am still working on the indenting from
your last one), but have a few remarks:

1) could you provide a log message conforming to conventions described in
HACKING please?
2) your "added everywhere" above means that this is the last one? Or did you
work on a per library basis and is this everywhere for the next few
libraries? (Something to document in your log messag)
3) You have wrapped over long lines nicely, but could you please indent them
differently? Here's an example from your diff:

- "Failed to add directory '%s': object of the same name already
- db->path);
+ _("Failed to add directory '%s': object of the same name "
+ "already exists"), db->path);

should be indented:
+ _("Failed to add directory '%s': object of the same name "
+ "already exists"), db->path);

Thanks in advance!



NEU : GMX Internet.FreeDSL
Ab sofort DSL-Tarif ohne Grundgebühr: http://www.gmx.net/info
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org
Received on Sun Apr 11 09:47:58 2004

This is an archived mail posted to the Subversion Dev mailing list.

This site is subject to the Apache Privacy Policy and the Apache Public Forum Archive Policy.