[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: ra_dav Protocol for the trace_old_file_location Function

From: Shlomi Fish <shlomif_at_iglu.org.il>
Date: 2004-04-08 19:20:18 CEST

On Thursday 08 April 2004 16:30, C. Michael Pilato wrote:
> Shlomi Fish <shlomif@iglu.org.il> writes:
> > Hi!
> >
> > The purpose of this E-mail is to suggest a protocol for the
> > trace_old_file_location function over WebDAV/DeltaV (to be
> > implemented as a client in libsvn_ra_dav and as a server in
> > mod_dav_svn). The function will use a REPORT request, with the
> > following customized XML Body:
> Adamently opposed to "trace_old_file_location". Don't box us into
> this one operation, please. I'd much rather have the RA interface
> called just RA->get_locations()

Just "get_locations"? This is too generic a name and could mean all sort of
things. How about "get_past_locations"?

> svn_error_t *
> get_locations (apr_hash_t **locations,
> const char *path,
> svn_revnum_t peg_revision,
> apr_array_header_t *location_revisions,
> apr_pool_t *pool);
> Allow folks to pass a path, a peg revision, and a set of location
> revisions. The return hash maps those same location revisions to
> the location paths.

OK. Should the location_revisions be sorted before calling the function?
Otherwise, the implementation would have to sort them.

> DAV REPORT request protocol would look similar to what you suggested,
> save for <S:get-locations> instead of <S:trace-old-file-location>,
> <S:location-revision> instead of <S:past-revision>, and the ability
> to specify many <S:location-revision> tags.

I still don't think it is wise to simply call it "location-revision" or

> DAV REPORT response protocol would be something like:
> <S:get-location-report xmlns...>
> <S:location>
> <S:location-revision>45</S:location-revision>
> <D:href>http://localhost/svn/repos/my-old-file.txt</D:href>
> </S:location>
> <S:location>
> <S:location-revision>56</S:location-revision>
> <D:href>http://localhost/svn/repos/my-other-old-file.txt</D:href>
> </S:location>
> ...
> </S:get-location-report>
> If the PATH@PEG-REVISION doesn't exist, you get a 404. Otherwise,
> revisions in which the path didn't exist simply don't show up in the
> response.

Sounds fair.


        Shlomi Fish

Shlomi Fish shlomif@iglu.org.il
Homepage: http://shlomif.il.eu.org/

Quidquid latine dictum sit, altum viditur.
        [Whatever is said in Latin sounds profound.]

To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org
Received on Thu Apr 8 19:15:05 2004

This is an archived mail posted to the Subversion Dev mailing list.

This site is subject to the Apache Privacy Policy and the Apache Public Forum Archive Policy.