[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: [PATCH] Fix to svn_time_to_human_cstring() - take 3

From: Ben Reser <ben_at_reser.org>
Date: 2004-04-06 02:06:35 CEST

On Sun, Apr 04, 2004 at 04:28:17PM -0300, Nicol?s_Lichtmaier wrote:
> + else
> + {
> + const char *utf8_string;
> + svn_error_t *err;
>
> + err = svn_utf_cstring_to_utf8(&utf8_string, human_datestr, pool);
> + if(err)
> + {
> + *curptr = '\0';
> + svn_error_clear(err);
> + }
> + else
> + apr_cpystrn(curptr, utf8_string, SVN_TIME__MAX_LENGTH - len);
> + }
> +

You're also not following the convention of putting a space before a (.
This is flexible, but this file appears to be consistent in this case.
So you should follow what's being used in that file.

-- 
Ben Reser <ben@reser.org>
http://ben.reser.org
"Conscience is the inner voice which warns us somebody may be looking."
- H.L. Mencken
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org
Received on Tue Apr 6 02:06:48 2004

This is an archived mail posted to the Subversion Dev mailing list.

This site is subject to the Apache Privacy Policy and the Apache Public Forum Archive Policy.