Re: [PATCH] Fix to svn_time_to_human_cstring() - take 3

On Sun, Apr 04, 2004 at 08:34:15PM +0100, Philip Martin wrote:
> Nicol?s Lichtmaier <nick@reloco.com.ar> writes:
>
> > + else
> > + {
> > + const char *utf8_string;
> > + svn_error_t *err;
> >
> > + err = svn_utf_cstring_to_utf8(&utf8_string, human_datestr, pool);
> > + if(err)
> > + {
> > + *curptr = '\0';
> > + svn_error_clear(err);
>
> I'm not sure it's valid to ignore this error.
>
> > + }
> > + else
> > + apr_cpystrn(curptr, utf8_string, SVN_TIME__MAX_LENGTH - len);
> > + }
> > +
> > return datestr;
> > }

The else statement still isn't compliant with the style we follow.

if (err)
  {
    ..
  }
else
  ..

Please refer to HACKING and
http://www.gnu.org/prep/standards_23.html#SEC23

-- 
Ben Reser <ben@reser.org>
http://ben.reser.org
"Conscience is the inner voice which warns us somebody may be looking."
- H.L. Mencken
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org