Re: svn commit: r9280 - in trunk/subversion: include libsvn_delta

Greg Stein wrote:
> On Sat, Apr 03, 2004 at 09:23:33AM -0600, bliss@tigris.org wrote:
>
>>...
>>* subversion/include/svn_types.h
>> (SVN_STREAM_CHUNK_SIZE): Reduce from 100 kiB to 8 kiB.
>
> I don't think this is possible to do. It feels like an API change. Changes
> around functions are very straight-forward to tell what is compatible, and
> what isn't. Symbolic constants are trickier. It is quite likely that
> somebody uses this to define a buffer size somewhere, and now it is
> possible that two blocks of code, compiled at different times, are going
> to disagree on that size.

Roger that. I really doubt that anyone uses it, and I don't like that
it's published, but since it is, I have to agree.

> So... -1 on this change, unless we can determine that it definitely won't
> be a problem. (but I can't see that)

I don't see how anyone could prove such a thing, at least not in the
mathematical sense. It's reverted in r9288.

/Tobias

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org
Received on Mon Apr 5 21:02:02 2004