[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: svn commit: r9280 - in trunk/subversion: include libsvn_delta

From: Greg Stein <gstein_at_lyra.org>
Date: 2004-04-05 20:21:07 CEST

On Sat, Apr 03, 2004 at 09:23:33AM -0600, bliss@tigris.org wrote:
>...
> * subversion/include/svn_types.h
> (SVN_STREAM_CHUNK_SIZE): Reduce from 100 kiB to 8 kiB.

I don't think this is possible to do. It feels like an API change. Changes
around functions are very straight-forward to tell what is compatible, and
what isn't. Symbolic constants are trickier. It is quite likely that
somebody uses this to define a buffer size somewhere, and now it is
possible that two blocks of code, compiled at different times, are going
to disagree on that size.

So... -1 on this change, unless we can determine that it definitely won't
be a problem. (but I can't see that)

Cheers,
-g

-- 
Greg Stein, http://www.lyra.org/
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org
Received on Mon Apr 5 20:20:25 2004

This is an archived mail posted to the Subversion Dev mailing list.

This site is subject to the Apache Privacy Policy and the Apache Public Forum Archive Policy.