[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: [PATCH] Allow export to export svn:eol-style=native files with a user suplied eol marker.

From: Greg Hudson <ghudson_at_MIT.EDU>
Date: 2004-04-04 21:59:24 CEST

On Sun, 2004-04-04 at 15:53, Philip Martin wrote:
> +static void
> +get_eol_style (svn_subst_eol_style_t *style,
> + const char **eol,
> + const char *value,
> + const char *native_eol)
> +{
> + svn_subst_eol_style_from_value (style, eol, value);
> + if (native_eol && *style == svn_subst_eol_style_native)
> + svn_subst_eol_style_from_value (NULL, eol, native_eol)
> +}

Hm. That erroneously accepts "native", but I guess that's no big deal
if the command-line client is filtering for that.

Also, we don't document that NULL is an acceptable first argument to
svn_subst_eol_style_from_value. We should fix the documentation before
adding any (more) call sites which rely on that bit of defensiveness.

To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org
Received on Sun Apr 4 21:59:48 2004

This is an archived mail posted to the Subversion Dev mailing list.

This site is subject to the Apache Privacy Policy and the Apache Public Forum Archive Policy.