[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: [PATCH] Allow export to export svn:eol-style=native files with a user suplied eol marker.

From: Philip Martin <philip_at_codematters.co.uk>
Date: 2004-04-04 21:43:46 CEST

Greg Hudson <ghudson@MIT.EDU> writes:

> On Sun, 2004-04-04 at 15:28, Philip Martin wrote:
>> > + svn_subst_eol_style_from_value (style, eol, value);
>> > + if (native_eol && *style == svn_subst_eol_style_native)
>> > + {
>> > + if (! strcmp ("LF", native_eol))
>> > + *eol = "\n";
>> > + else if (! strcmp ("CR", native_eol))
>> > + *eol = "\r";
>> > + else if (! strcmp ("CRLF", native_eol))
>> > + *eol = "\r\n";
>> > + /* else leave *eol alone */
>>
>> svn_subst_eol_style_native (NULL, eol, native_eol) ?
>
> I don't understand this comment at all.

Rather than do

       if (native_eol == lf)
         ...
       else if (native_eol == cr)
         ...
       else if (native_eol == crlf)
         ...

call
       svn_subst_eol_style_native (native_eol)

-- 
Philip Martin
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org
Received on Sun Apr 4 21:44:02 2004

This is an archived mail posted to the Subversion Dev mailing list.

This site is subject to the Apache Privacy Policy and the Apache Public Forum Archive Policy.