Re: [PATCH] Allow export to export svn:eol-style=native files with a user suplied eol marker.

On Sun, 2004-04-04 at 15:28, Philip Martin wrote:
> > + svn_subst_eol_style_from_value (style, eol, value);
> > + if (native_eol && *style == svn_subst_eol_style_native)
> > + {
> > + if (! strcmp ("LF", native_eol))
> > + *eol = "\n";
> > + else if (! strcmp ("CR", native_eol))
> > + *eol = "\r";
> > + else if (! strcmp ("CRLF", native_eol))
> > + *eol = "\r\n";
> > + /* else leave *eol alone */
>
> svn_subst_eol_style_native (NULL, eol, native_eol) ?

I don't understand this comment at all.

> > + case svn_cl__native_eol_opt:
> > + if ( !strcmp ("LF", opt_arg) || !strcmp ("CR", opt_arg) ||
> > + !strcmp ("CRLF", opt_arg))
>
> For consistency with propset feel we ought to support the no-op
> "native" as well?

I dislike that idea. There's no compelling reason to provide a way to
say "override the native EOL style with... I've changed my mind,
actually, don't."

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org
Received on Sun Apr 4 21:40:26 2004