[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Log Message [was Re: [PATCH] Trace Past URL From Peg Revision - rev 5]

From: Shlomi Fish <shlomif_at_iglu.org.il>
Date: 2004-04-03 13:37:42 CEST

On Friday 02 April 2004 21:07, Ben Collins-Sussman wrote:
> On Fri, 2004-04-02 at 13:07, Shlomi Fish wrote:
> > Here is a new revision:
> >
> > http://shlomif.il.eu.org/svn-patches/peg-revision-patch-rev8.patch
> >
> > Changes since last time:
> >
> > 1. More tests added.
> >
> > 2. Made the tests' interface more robust.
> >
> > 3. The standalone command line client for the peg function can now open
> > http:// URLs. (albeit still segfaults afterwards because the handler in
> > the vtable is not implemented.)
> You still haven't written a log message. This is the single biggest
> obstacle preventing people from paying attention to the patch.

Very well, here's a new patch that is this time accompanied with a log message
(a Passover present just for you):


And here's the log message:

Adds an libsvn_fs layer function to efficiently trace the file historical
location based on its peg revision+URL. Also adds a callack that implements
it to the RA vtable and bindings to it from libsvn_ra_local.

* build.conf
  Compile ra-get-past-location, which is a command line client for this
  functionality to facilitate testing.

* include/svn_fs.h
  Added the declaration of svn_fs_trace_old_file_location() which is the
  function that does the tracing of a historical location within the

* include/svn_ra.h
  Added the trace_old_file_location binding to the bottom of svn_ra_plugin_t.

* libsvn_fs/tree.c
  Added the definition of svn_fs_trace_old_file_location.

* libsvn_ra_local/ra_plugin.c
  Added the definition of svn_ra_local__trace_old_file_location, a binding
  to the RA vtable callback that handles the operation.
  Added it to the end of the libsvn_ra_local vtable.

* tests/libsvn_ra_local/get-past-location.c
  (new file): a simple standalone command line client that queries for
  the historical URL at a past revision of a certain URL at a peg revision.

* tests/clients/cmdline/past_loc_tests.py
  (new file): a test suite to test the past revision functionality.

> You said
> you "didn't have time" to write one yesterday, yet you've spent time
> since then adding more code instead (?)

I went over my IRC logs and the E-mail messages and could not find a single
place where I said that. What I meant is that the functionality is still not
implemented in all the places it should be, and so I'd rather not write a log
message at this point.


        Shlomi Fish

> Don't underestimate the importance of the log message, or the importance
> of responding to feedback from other developers. Participating in an
> open-source project is more than just throwing patches over a wall. :-)

Shlomi Fish      shlomif@iglu.org.il
Homepage:        http://shlomif.il.eu.org/
Quidquid latine dictum sit, altum viditur.
        [Whatever is said in Latin sounds profound.]
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org
Received on Sat Apr 3 13:32:43 2004

This is an archived mail posted to the Subversion Dev mailing list.

This site is subject to the Apache Privacy Policy and the Apache Public Forum Archive Policy.